Open
Conversation
only file deleting is left at post DFW stage. Added missed object type of TABLESPACES. Added security class for tablespaces which allows not to skip check of the privileges. Corrected page space before fetching of the root index page.
…code as for deleting a table. NOTE: Now we fire DDL trigger for deleling tables even if they are deleting as result of DROP TABLESPACE ... INCLUDING CONTENTS
…nt of usage have the page space in the pace space manager. Also the same behaviour has been ported to the expression index handling.
The recent change added a couple of new fields into CreationIndex which were not initialized before fast loading while index moving.
…RELATION_ID is NULL in that case
…g, adding and deleting page spaces
…espace creation Page space should be added into pageSpaces array after creating/opening of tablespace file to prevent other attachments from getting incomplete page space.
…ME> INCLUDING CONTENTS. Deleting from tablespaces cache is implemented.
…e rollback work correctly. The file will be created at DFW stage
…opped in the same transaction
… A relation may already be deleted by dfw_delete_relation in the same transaction
It allows to determine if there are attachments that use a tablespace (and have its page space opened) when another attachment needs the EX lock on that tablespace (for example, to execute ALTER TABLESPACE).
… make it work correctly
…file containing an index is unsuccessful
…rash while trying to write dirty pages of closed tablespace to disk
…ropped in the same transaction
Contributor
|
I didn't find a README.tablespaces file in this PR. |
Contributor
Author
Will be added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to proposal: https://groups.google.com/g/firebird-devel/c/geF0A2_kC28